SLOP-394: require edit token for ?unreview= write (CSRF) in Special:PageStatistics - #10
Open
tosfos wants to merge 1 commit into
Open
SLOP-394: require edit token for ?unreview= write (CSRF) in Special:PageStatistics#10tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
Special:PageStatistics?unreview=<ts> rewrote the acting user\x27s wl_notificationtimestamp on any GET with no token check, and wrote the timestamp value unvalidated. Require the user\x27s edit token and embed it in the ReviewHandler right-click fallback URL.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Special:PageStatistics?unreview=<timestamp>callsReviewHandler::resetNotificationTimestamp(), which performs a rawUPDATE watchlist SET wl_notificationtimestamp = ...for the acting user — with no token check, triggered by a plain GET. Any page, link, or<img>tag can silently rewrite the victim's review timestamps. The timestamp value was also written to the DB completely unvalidated.Fix:
SpecialPageStatistics::execute()requires the user's edit token (matchEditToken) before performing the unreview write, throwingPermissionsError('editmywatchlist')otherwise.ReviewHandler::getTemplate()embeds the token in the right-click fallback URL so the normal UI path keeps working.resetNotificationTimestamp, since that method is being rewritten anyway.)Verification
php -lclean on php:7.4-cli and php:8.2-cli for both files.PermissionsError(NEW); tokened request → write succeeds; tokened request with malicious timestamp payload → rejected.Closes SLOP-394.